Fix #173: HTTPS request doesn't work when disable_ssl_certificate_validation=True #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise CertificateValidationUnsupportedInPython31() | ||
| context = ssl.SSLContext(ssl.PROTOCOL_TLSv1) | ||
| if not hasattr(ssl, 'SSLContext'): | ||
| raise CertificateValidationUnsupportedInPython31() |
There was a problem hiding this comment.
I'm pretty sure this causes Python 3.1 to always raise an exception, even when certification validation is explicitly not disabled, - i.e. when disable_ssl_certificate_validation is enabled.
fwiw, there is another pending patch for this issue; pull #269 , which has bitrotted.
There was a problem hiding this comment.
@jayvdb you are totally right, I'll update the patch.
* `ssl.SSLContext` is new in Python 3.2 and all of the features used here are available from then on. * The when using an `SSLContext` the `check_hostname` kwarg *requires* that `context.verify_mode` be set to **either** `ssl.CERT_REQUIRED` **or** `ssl.CERT_OPTIONAL`. `ssl.CERT_NONE` raises an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
SSLContext.verify_modetossl.CERT_OPTIONALifdisable_ssl_certificate_validationisTrueotherwise it is set tossl.CERT_REQUIRED.