Added clear_user_list function to wrapper#6
Open
kalinon wants to merge 3 commits intojbreeden:masterfrom
Open
Conversation
Owner
|
For me, the rubocop changes are a bit much, even though it mostly looks like an improvement. I'd be happy to merge the additional clear_user_list wrapper on its own. I can squash the extra changes out if need be, but I'm guessing I'll procrastinate even longer if that's the case :P I just need to find some time for testing, and maybe setting up automated testing for this repo. Thanks for the PR! |
Author
|
Yeah I always get scolded for my rubocop updates. I just run it on auto
format and forget about it. When I get the chance I’ll isolate the commit
if I can.
…On Tue, Apr 3, 2018 at 10:49 AM Jared Breeden ***@***.***> wrote:
For me, the rubocop changes are a bit much, even though it mostly looks
like an improvement. I'd be happy to merge the additional clear_user_list
wrapper on its own. I can squash the extra changes out if need be, but I'm
guessing I'll procrastinate even longer if that's the case :P
I just need to find some time for testing, and maybe setting up automated
testing for this repo.
Thanks for the PR!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFXk7Fk9FLSJAW30_Ut_xIgU6wNN1hh6ks5tk4vjgaJpZM4R4l-w>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clear_user_list function to wrapper