Skip to content

Conversation

@johnpoth
Copy link

@johnpoth johnpoth commented Sep 5, 2025

(cherry picked from commit 41a50e0)

rebase from fusesource#37

@cunningt hope this is ok. I'll copy paste the original comments here for ease of use:

As we discussed, this is a PR that demonstrates users installing the three SAP libraries in their Maven repository instead of using a lib folder. So for example using version 3.1.4 for sapjco and 3.1.1 for sapidoc on Linux x86 64 bit the user would have to run three commands:

  1. mvn install:install-file -DgroupId=com.sap.conn.jco -DartifactId=sapjco3 -Dversion=3.1.4 -Dpackaging=jar -Dfile=sapjco3.jar

  2. mvn install:install-file -DgroupId=com.sap.conn.idoc -DartifactId=sapidoc3 -Dversion=3.1.1 -Dpackaging=jar -Dfile=sapidoc3.jar

  3. mvn install:install-file -DgroupId=com.sap.conn.jco -DartifactId=sapjco3 -Dversion=3.1.4 -Dclassifier=linux-x86_64 -Dpackaging=so -Dfile=libsapjco3.so

Some drawbacks compared to using the lib folder strategy:

  1. If the user uses a different version for sapjco or sapidoc, he has to update the pom.xml
  2. The command for the native library is OS dependent so error prone. If a different classifier was used the pom.xml also has to be updated.
  3. The standalone version of the quickstarts (not sure if we should keep them here or not as this is for SpringBoot) uses the Camel Maven Plugin which doesn't have an option to add extra dependencies. We would therefore have to use the lib folder strategy.

Given those drawbacks I think I prefer keeping the lib folder strategy but maybe I'm missing something. We can improve on it as @luigidemasi suggested and use a single lib folder too.

Let me know what you think!

@johnpoth johnpoth marked this pull request as draft September 5, 2025 11:43
@johnpoth johnpoth marked this pull request as ready for review September 5, 2025 15:03
@cunningt cunningt requested review from Croway and mcarlett September 5, 2025 15:05
@Croway
Copy link

Croway commented Sep 5, 2025

I am afraid that documentation in these quickstart will be pretty much lost.. would it be possible to provide this (or similar) documentation to the doc team? so that it can be published downstream?

@cunningt
Copy link
Collaborator

cunningt commented Sep 5, 2025

I am afraid that documentation in these quickstart will be pretty much lost.. would it be possible to provide this (or similar) documentation to the doc team? so that it can be published downstream?

Talked to Federico about this - I think we're okay here. The only doc-related changes here are README.md formatting changes and changes to the product name ("JBoss Fuse" -> "Red Hat build of Apache Camel"). I think the documentation around SAP that the doc team would need is all in jboss-fuse/fuse-components and to a smaller extent the camel-sap-starter in camel-spring-boot.

@cunningt cunningt changed the title Draft: install SAP libs in the Maven local repository Install SAP libs in the Maven local repository Sep 5, 2025
@johnpoth johnpoth merged commit d16d589 into camel-4.14.0-branch Sep 8, 2025
@johnpoth johnpoth deleted the libs branch September 8, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants