-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing merge queues @ GitHub Actions CI/CD #1990
Enable testing merge queues @ GitHub Actions CI/CD #1990
Conversation
Hey @jezdez, could you go to the repo's branch protection settings, and enable merge queues there, once this PR is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! I've seen this over at PyPUG.
@webknjaz done, using squash commits |
@webknjaz It's not a multiple choice config, here are the options: |
@jezdez then, use merge. It'll make them octopus. Also, I'd drop that checkbox for "only failing" — sometimes, several failing PRs composed will result in a green CI. |
@webknjaz 👍🏻 |
@jezdez thanks! This will help reduce the need for people to "merge main into PR" all the time since the merge queue will take care of checking that several PRs play well together. |
That's unrelated. The scheduled nightly runs have a slightly different CI matrix which includes testing against the very last commit in the Pip's repository — that's what's failing. |
This patch allows the project to start using merge queues. They will still have to be enabled in the branch protection settings.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.