Always disable cProfile as part of cleanup #699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #692 , this diff cleans up two places where cProfile is enabled but not disabled.
In
collector.py
, theDataCollector()._configure()
logic is changed so that the profiler is explicitly stopped before the profiler is set toNone
. If the profile is set toNone
, future profiles are blocked even though the old profiler is not accessible and pending garbage collection.In
test_execute_sql.py
, the test cases are enabling profiling throughDataCollector
but the test cases are not explicitly disabling profiling when finished. This causes other test cases to fail when they attempt to profile. (I'm not sure why these test cases explicitly require disabling profiling even though many other test cases also initializeDataCollector
and enable profiling)#692 should have caught this but it turns out that
tox.ini
is configured to ignore djmain and by extension due to the test version matrix, most python 3.12 failures.