Clarify max body size units and format readme #695
Conversation
There was a problem hiding this comment.
Hey @AbhiMisRaw, welcome to the django-silk! Awesome first contribution—thanks for catching that docs issue and making the update to BYTE. It looks perfect!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 52 52
Lines 2113 2113
=======================================
Hits 1831 1831
Misses 282 282 ☔ View full report in Codecov by Sentry. |
| SILKY_MAX_REQUEST_BYTE_SIZE = -1 # Silk takes anything <0 as no limit | ||
| SILKY_MAX_RESPONSE_BYTE_SIZE = 1024 # If response body>1024 bytes, ignore |
There was a problem hiding this comment.
SILKY_MAX_REQUEST_BODY_SIZE is being read within django-silk: https://github.com/search?q=repo%3Ajazzband%2Fdjango-silk%20SILKY_MAX_RESPONSE_BODY_SIZE&type=code
The variable cannot be changed to SILKY_MAX_RESPONSE_BYTE_SIZE in the readme without updating the code within django-silk (which would be a bad idea because it would require users of django-silk to update their code as it would be backwards incompatible)
albertyw
changed the title
albertyw
changed the title
|
The issue with |
It's my first contribution, as @SebCorbin said, It's an docs issue, so I've updated it
BODY -> BYTEFixes #300