-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of Oracle #258
Conversation
@pikhovkin I appreciate the effort to add Oracle support for django-silk. I see 2 PR's open. Is there a reason for that? Should those be discarded and this one be the only one for consideration to merge in? |
You can remove 2 others PR's. |
It seems the tests are failing. Can you fix them? Also, does travis support oracle as a DB? If it does, it would be nice to add to |
We must get rid of the UUID fields, because django Oracle backend interprets them in SQL as a number, because of this an error occurs. |
@albertyw I have not worked yet with travis or other like system. |
@albertyw, please, look erroneous tests https://travis-ci.org/jazzband/django-silk/builds/329821906 |
@pikhovkin This PR needs a rebase to the latest django-silk:master, can you work this? |
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
===========================================
- Coverage 82.87% 31.46% -51.42%
===========================================
Files 50 52 +2
Lines 2055 2082 +27
===========================================
- Hits 1703 655 -1048
- Misses 352 1427 +1075
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we moved to github actions, the tests needed to pass
Well, I messed up trying to work on the fork, I have opened another PR to continue discussion in #619 |
Added support of Oracle