Show full admin context (breadcrumb and logout nav) in model type selection admin form #580
+118
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi! Thanks for opening this PR. Could you please elaborate a bit more? What was the issue you where seeing? Is there any unit test you could add? Thank you! |
Contributor
|
Contributor
|
The issue described here is that the breadcrumbs, logout and admin nav disappear in the polymorphic model type selection form. I'm going to accept this PR, but I need to add tests and rebase. Without fix: With fix: 
|
bckohan
force-pushed
the
parentadmin-behave-as-admin
branch
from
1d62780 to
179bc3d
Compare
bckohan
changed the title
bckohan
force-pushed
the
parentadmin-behave-as-admin
branch
2 times, most recently
from
a66d42a to
f8f1b63
Compare
- fix parent admin form not behaving like an admin form (eg log out button context missing) - add test for model type add form correctly embedding in the rest of the admin - separate playwright admin form tests - update changelog Co-authored-by: TarunvirBains <[email protected]> Co-authored-by: Brian Kohan <[email protected]>
bckohan
force-pushed
the
parentadmin-behave-as-admin
branch
from
f8f1b63 to
47323bd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 73.97% 74.71% +0.74%
==========================================
Files 21 21
Lines 1337 1337
Branches 211 211
==========================================
+ Hits 989 999 +10
+ Misses 266 261 -5
+ Partials 82 77 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix parent admin form not behaving like an admin form (eg log out button context missing)