-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSONField for BasePayment.attrs #306
base: main
Are you sure you want to change the base?
Conversation
Hi! I'm actually wanting to use this, since 2.2 has already been dropped, can I give you a hand with this? |
I've rebased this, but it would be good to have some more testing before merging it. |
I'll start using it right away, and let you know, my system processes a couple thousands purchases a day, so it's a fair trial. |
Tests seem to still be failing on a bunch on combinations of Django + Python, so I'd hold testing it on a production environment for a bit. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 78.42% 77.95% -0.48%
==========================================
Files 29 29
Lines 1979 1964 -15
Branches 244 244
==========================================
- Hits 1552 1531 -21
- Misses 310 317 +7
+ Partials 117 116 -1 ☔ View full report in Codecov by Sentry. |
Looks like f4dfa5e is breaking some tests, but it's not clear to me why. |
Split the first commit into #385 |
Need to wait until Django 2.2 is EOL.