-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pg_dump): Add '--if-exists' option for pg_dump #511
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 91.40% 91.03% -0.38%
==========================================
Files 19 19
Lines 873 859 -14
Branches 157 151 -6
==========================================
- Hits 798 782 -16
- Misses 40 41 +1
- Partials 35 36 +1 ☔ View full report in Codecov by Sentry. |
I'm a bit uninformed here, but do you believe Also this can be merged after you create a simple unit test. |
Hey @Archmonger , |
Okay, I'm going to assume that you're saying having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged after you create a simple unit test.
Tests are broken, will need to be fixed. |
Should be fixed in my branch. Sorry about that. |
@DmytroLitvinov Can you remerge with his branch? |
@Archmonger , could you help with the issue in CI? |
Seems to be related the Python v3.7 tests
|
Marking this as draft due to tests failing |
Description
Add option
--if-exists
for pg_dump command.Resolves #478
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).