Skip to content

Dashboard: /api/prs gives viewers the merge decision's hold reasons (found by #741's builder) #821

Closed

Description

@jayden1711

Outcome: a viewer sees no more of a PR's merge decision than /api/state and /api/events already show viewers. That's the same rule #741 (PR #816) applies to its first-task card, where viewers get 403 and no hold reason.

Why:

Do:

  1. Measure it: a viewer session calls /api/prs against a fixture with a held PR.
  2. If reasons are visible, scope them to writers. Viewers get the state only (waiting/merged), as elsewhere.
  3. Add a test that fails without the change.

Review point: src/** is protected, so the owner merges.

Related: #741, #816, #706.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions