Skip to content

Convert IFRT's kString dtype to NumPy's variable length string dtype. #32274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert IFRT's kString dtype to NumPy's variable length string dtype. #32274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/string_array_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def test_single_device_array(self, asarray):
jax_string_array = jax.device_put(
numpy_string_array, device=cpu_devices[0]
)
self.assertEqual(jax_string_array.dtype, np.dtypes.StringDType()) # type: ignore
jax_string_array.block_until_ready()

array_read_back = jax.device_get(jax_string_array)
Expand Down Expand Up @@ -93,8 +94,13 @@ def test_multi_device_array(self, asarray):
jax_string_array = jnp.asarray(numpy_string_array, device=sharding)
else:
jax_string_array = jax.device_put(numpy_string_array, device=sharding)
self.assertEqual(jax_string_array.dtype, np.dtypes.StringDType()) # type: ignore
jax_string_array.block_until_ready()

self.assertLen(jax_string_array._arrays, 2)
for a in jax_string_array._arrays:
self.assertEqual(a.dtype, np.dtypes.StringDType()) # type: ignore

array_read_back = jax.device_get(jax_string_array)
self.assertEqual(array_read_back.dtype, np.dtypes.StringDType()) # type: ignore
np.testing.assert_array_equal(array_read_back, numpy_string_array)
Expand Down
Loading