Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves postgres enum support by making
as const
not needed in conditions when creating conditions for columns with enum types.This typescript feature requires typescript 5.0. This might be problematic because the peer dependency is
"typescript": ">=4.1"
.This is an example of the problem this PR is trying to fix.
Schema
Before this change, the following code has a typescript error:
The reason it has a typescript error is because the type of
db.conditions.ne('Waiting')
is inferred to beSQLFragment<boolean | null, string>
, which is not a subtype ofdb.SQLFragment<any, enum_profile_avail_check_status>
. A workaround is to instead doWith the workaround,
db.conditions.ne('Waiting')
is inferred to beSQLFragment<boolean | null, 'Waiting'>
which is a subtype ofdb.SQLFragment<any, enum_profile_avail_check_status>
. However, it can be annoying to remember this workaround.This PR removes the need for the workaround by telling typescript to infer the narrowest type possible for the parameter.