Add speed control #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonher937
reviewed
Mar 7, 2023
| @@ -100,6 +110,18 @@ pub fn simple_example( | |||
| Ok(Message::Backward) => mpv | |||
| .command(&["seek", "-5"]) | |||
| .expect("Error setting MPV property"), | |||
| Ok(Message::SpeedUp) => { | |||
| let speed: f64 = mpv.get_property("speed").unwrap(); | |||
| let new_speed: f64 = (speed + 0.25).min(5.0); | |||
There was a problem hiding this comment.
I'm no rust dev, but should min not be max here?
There was a problem hiding this comment.
I think he is trying to set a max allowed value.
He check min(speed + 0.25 vs 5.0), so the max alowed value will be 5.0.
For example if speed is 5.0 and u try to speed up you will stand on 5.0 due to min check.
On the other hand... I think SpeedDown method is wrong, it should be max.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.