Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM and events #550

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Conversation

joaquinelio
Copy link
Member

No description provided.

8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved
8-web-components/7-shadow-dom-events/article.md Outdated Show resolved Hide resolved

## Bubbling, event.composedPath()
## Propagación, event.composedPath()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio yo creo que lo dejamos como Propagación

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dbritto-dev
Copy link
Contributor

@joaquinelio todo tuyo :D

@joaquinelio
Copy link
Member Author

gracias!!! @dbritto-dev
gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo,
es usual que aparezca en codigo o como propiedad element.shadowRoot
pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc.
gracias, volveré luego

@dbritto-dev
Copy link
Contributor

gracias!!! @dbritto-dev gúilcombác

shadow-??????

Uf. Lo voy a poner como issue. Hay que cepillar el repo con esto.

AHORA estoy de acuerdo, es usual que aparezca en codigo o como propiedad element.shadowRoot pero no me vas a convencer de que "shadow and light" es una palabra compuesta.

setear

demasiado usual y se me escapo... pero acordate, los que usamos estas pocas aberraciones vamos a lograr que el drae las registre.

etc. gracias, volveré luego

falto traducir el and en shadow and light, hahaha :)


## Bubbling, event.composedPath()
## Propagación, event.composedPath()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es correcto,
pero me suena feo...
¿cuanto insistis con esto? me dejo convencer facil

@joaquinelio
Copy link
Member Author

/done

@joaquinelio
Copy link
Member Author

mentira /done, ¿si hago el ultimo commit puedo darle merge?

¡falta un solo articulo para terminar el repo!!
y estos 2 pr, si queres podes echarle un vistazo al otro...
especialmente si usaste regex

@joaquinelio
Copy link
Member Author

biutiful

@joaquinelio joaquinelio merged commit ea8f513 into javascript-tutorial:master Dec 16, 2021
@joaquinelio joaquinelio deleted the shave branch December 16, 2021 12:11
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants