Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#122 fix some translation issues #123

Merged
merged 1 commit into from
Dec 18, 2023
Merged

#122 fix some translation issues #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/kotlin/ir/thatsmejavad/backgroundable/model/Contributor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package ir.thatsmejavad.backgroundable.model

import androidx.annotation.DrawableRes
import androidx.annotation.StringRes

data class Contributor(
val name: String,
val position: String,
@StringRes val name: Int,
@StringRes val position: Int,
@DrawableRes val image: Int,
val links: List<ContributorLink>
)
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/kotlin/ir/thatsmejavad/backgroundable/screens/aboutus/AboutUsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ private fun ContributorItem(
) {
Text(
modifier = Modifier.align(CenterHorizontally),
text = contributor.name,
text = stringResource(contributor.name),
style = MaterialTheme.typography.titleMedium,
color = MaterialTheme.colorScheme.onSurface,
)
Expand All @@ -131,7 +131,7 @@ private fun ContributorItem(

Text(
modifier = Modifier.align(CenterHorizontally),
text = contributor.position,
text = stringResource(contributor.position),
style = MaterialTheme.typography.titleMedium,
color = MaterialTheme.colorScheme.surfaceTint,
)
Expand Down Expand Up @@ -250,8 +250,8 @@ private fun BackgroundableAbout() {

val contributors = listOf(
Contributor(
name = "Javad Jafari",
position = "Android Developer",
name = R.string.label_javad_name,
position = R.string.label_android_developer,
image = R.drawable.jai_photo,
links = listOf(
ContributorLink(
Expand All @@ -272,8 +272,8 @@ val contributors = listOf(
)
),
Contributor(
name = "Mohammad Ghasemi",
position = "UI/UX Designer",
name = R.string.label_mmd_name,
position = R.string.label_designer,
image = R.drawable.mmd_photo,
links = listOf(
ContributorLink(
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values-fa/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,8 @@
<string name="label_tiny">خیلی کوچک</string>
<string name="label_language">زبان</string>
<string name="label_report_a_bug">گزارش مشکل</string>
<string name="label_javad_name">جواد جعفری</string>
<string name="label_android_developer">برنامه نویس اندروید</string>
<string name="label_mmd_name">محمد قاسمی</string>
<string name="label_designer">طراح رابط کاربری</string>
</resources>
4 changes: 4 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,8 @@
<string name="label_english_lang_desc" translatable="false">The text of the app changes to English</string>
<string name="label_persian_lang_desc" translatable="false">متن های برنامه به فارسی تغییر می کند</string>
<string name="label_report_a_bug">Report a bug</string>
<string name="label_javad_name">Javad Jafari</string>
<string name="label_android_developer">Android Developer</string>
<string name="label_mmd_name">Mohammad Ghasemi</string>
<string name="label_designer">UI/UX Designer</string>
</resources>