part3 (Kozyrev Egor) #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senia-psm
reviewed
Apr 18, 2017
| throw new UnsupportedOperationException(); | ||
| return inner.characteristics() | ||
| | NONNULL | ||
| | SIZED; |
There was a problem hiding this comment.
Incorrect.
Array may be bigger than the unsized inner.
| public boolean tryAdvance(Consumer<? super Pair<A, B>> action) { | ||
| // TODO | ||
| throw new UnsupportedOperationException(); | ||
| return (currentIndex < endIndex |
| public void forEachRemaining(Consumer<? super Pair<A, B>> action) { | ||
| // TODO | ||
| throw new UnsupportedOperationException(); | ||
| while (currentIndex < endIndex) { |
There was a problem hiding this comment.
Inefficient. You can optimize this in case inner.hasCharacteristics(SIZED).
| public Spliterator<Pair<A, B>> trySplit() { | ||
| // TODO | ||
| throw new UnsupportedOperationException(); | ||
| Spliterator<A> splitInner = this.inner.trySplit(); |
There was a problem hiding this comment.
Incorrect. Add test with not SIZED inner spliterator and parallel().
| public long estimateSize() { | ||
| // TODO | ||
| throw new UnsupportedOperationException(); | ||
| return endIndex - currentIndex; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.