Drozdov Igor lesson 4 #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senia-psm
reviewed
Jul 17, 2017
| return new ReachIterable<T>() { | ||
| @Override | ||
| public boolean tryGet(Consumer<T> consumer) { | ||
| return self.tryGet(t -> { |
There was a problem hiding this comment.
Incorrect. You should either return false or return true and call consumer.
| @Override | ||
| public boolean tryGet(final Consumer<R> consumer) { | ||
| boolean res = self.tryGet(t -> reachIterable = function.apply(t)); | ||
| while (reachIterable.tryGet(consumer)); |
There was a problem hiding this comment.
Incorrect. You should call consumer only once.
|
|
||
| default Optional<T> firstMatch(Predicate<T> predicate) { | ||
| final Object[] objects = new Object[1]; | ||
| while (tryGet(t -> { |
There was a problem hiding this comment.
Incorrect. firstMatch should be able to return value in case of infinite stream.
There was a problem hiding this comment.
It will return value, when test return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.