Nazarov_Anton/part-1 #162
Open
Nazarov_Anton/part-1 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senia-psm
reviewed
Jul 4, 2017
| Arrays.sort(persons, new Comparator<Person>() { | ||
| @Override | ||
| public int compare(Person o1, Person o2) { | ||
| return o2.getFirstName().compareTo(o1.getFirstName()); |
There was a problem hiding this comment.
See method name: sortPersonsByAge.
| @@ -18,7 +22,7 @@ public void sortPersonsByAge() { | |||
| new Person("name 2", "lastName 1", 30) | |||
| }; | |||
|
|
|||
| // TODO use Arrays.sort | |||
| Arrays.sort(persons, (o1, o2) -> Integer.valueOf(o1.getAge()).compareTo(o2.getAge())); | |||
There was a problem hiding this comment.
Use Comparator.comparingInt to avoid boxing.
Closed
senia-psm
reviewed
Jul 5, 2017
| @@ -27,7 +27,7 @@ public void sortPersonsByAge() { | |||
| Arrays.sort(persons, new Comparator<Person>() { | |||
| @Override | |||
| public int compare(Person o1, Person o2) { | |||
| return o2.getFirstName().compareTo(o1.getFirstName()); | |||
| return Comparator.<Person>comparingInt(Person::getAge).compare(o1, o2); | |||
There was a problem hiding this comment.
You are creating a new Comparator on each compare here.
Use Integer.compare.
senia-psm
reviewed
Jul 5, 2017
| @@ -22,7 +24,7 @@ public void sortPersonsByAge() { | |||
| new Person("name 2", "lastName 1", 30) | |||
| }; | |||
|
|
|||
| Arrays.sort(persons, (o1, o2) -> Integer.valueOf(o1.getAge()).compareTo(o2.getAge())); | |||
| Arrays.sort(persons, (o1, o2) -> Comparator.comparingInt(Person::getAge).compare(o1, o2)); | |||
There was a problem hiding this comment.
What is the type of Comparator.comparingInt(Person::getAge)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.