Skip to content

Part1 (by Vasilii Bobkov) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Part1 (by Vasilii Bobkov) #43

wants to merge 3 commits into from

Conversation

gloomygenius
Copy link

Part1 (by Vasilii Bobkov)

senia-psm
senia-psm reviewed Jul 26, 2017
View reviewed changes
src/test/java/part1/exercise/CompletableFutureBasics.java Outdated

// TODO Create completed CompletableFuture
final CompletableFuture<Person> futurePerson = null;
final CompletableFuture<Person> futurePerson = new CompletableFuture<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .completedFuture

src/test/java/part1/exercise/CompletableFutureBasics.java Outdated

// TODO Create completed CompletableFuture
final CompletableFuture<Person> futurePerson = null;
final CompletableFuture<Person> futurePerson = new CompletableFuture<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

src/test/java/part1/exercise/CompletableFutureBasics.java Outdated

// TODO Create completed CompletableFuture
final CompletableFuture<Person> futurePerson = null;
final CompletableFuture<Person> futurePerson = new CompletableFuture<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

src/test/java/part1/exercise/CompletableFutureBasics.java Outdated

// TODO Create completed CompletableFuture
final CompletableFuture<Person> futurePerson = null;
final CompletableFuture<Person> futurePerson = new CompletableFuture<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senia-psm senia-psm senia-psm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gloomygenius @senia-psm