Wezterm fixes #182
Merged
Wezterm fixes #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspervdj
reviewed
Feb 24, 2025
|
Had to push two commits because I forgot some debugging code. This should be working, but please let me know if anything else needs modification
To
|
jaspervdj
reviewed
Feb 25, 2025
|
Retested with these changes and everything seems to still work. Please let me know if anything else needs to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wezterm image support was not taking the terminal shape and any pane splits into account. This patch reads the dimensions through the Wezterm CLI to constrain the image dimensions to the active pane
Added deps:
There was an issue where the wezterm executable was hardcoded. This could probably use a bit more refinement into a configurable option, but as it stands there is a check to determine if "wezterm" or "wezterm.exe" are found as executables on the path.
Happy to make any changes that are needed