Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for WezTerm #177

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

feature-not-a-bug
Copy link
Contributor

This is a provisional attempt at adding image support for WezTerm. There's a new WezTerm.hs file that's modeled on the other Images folder files. I created a new getAspectRatio function that utilizes JuicyPixels to determine the aspect ratio of the image. If it's wider than tall width is fit to 100%, and if not the height is set to 95%. 100% on height clipped the bottom of the image. This probably doesn't belong in this file, but I don't have the ability to test with other terminals to see if this is necessary elsewhere.

Other minor changes are checking the environment in Main.hs to keep the cursor active.

Happy to have this reworked.

@feature-not-a-bug
Copy link
Contributor Author

Screenshot 2025-02-06 195219

Screenshot 2025-02-06 195254

Copy link
Owner

@jaspervdj jaspervdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made a few minor style comments but overall it looks good to me

@feature-not-a-bug
Copy link
Contributor Author

feature-not-a-bug commented Feb 9, 2025

I added a new commit with the recommended changes. Let me know if anything else needs to be modified. Everything tested ok on my end, but this does touch the ITerm2 file where withEscapeSequence is called and so any help confirming everything still works correctly on that would be appreciated.

@jaspervdj jaspervdj merged commit 0f951d6 into jaspervdj:main Feb 10, 2025
4 checks passed
@jaspervdj
Copy link
Owner

Thanks!

@feature-not-a-bug feature-not-a-bug deleted the wezterm branch February 10, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants