Fix density plots #352
Merged
Fix density plots #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll also fix the failing i18n check (see https://github.com/jasp-stats/jaspDescriptives/actions/runs/13316068109/job/37190295021?pr=351) so please don't merge this even if you review it. |
you can look at #349 I also pushed a fix for it. |
|
@shun2wang thanks! I merged your pr :) |
vandenman
force-pushed
the
fix_density_plots
branch
from
1dcd480 to
e17f103
Compare
|
Good catch @vandenman ! 
|
|
Oops @JohnnyDoorn good catch! Should be fixed now. |
JohnnyDoorn
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by @RensDofferhoff in 440f765
preferably next time open a PR so we can see if any unit tests fail 😅
because this is also broken in the current release:
This fix is more of a band-aid until we fully commit to preloadData.
@JohnnyDoorn let me know if you don't have time to review this!