chore(fonts): upgrade subset-font 2.5.0 to 2.9.0 - #656
Merged
Merged
Conversation
harfbuzzjs moves from 0.10.3 to 1.6.2. subset-font 2.9.0 drops its lodash dependency. The four files in dist-astro/fonts/ are byte-identical to the 2.5.0 build, and lockfileVersion stays 1. Refs #643
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
§11 order 7 now points at the PR that upgrades subset-font to 2.9.0.
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #643
Part of #635 (order 7). Base
preview. Blocked-by order 6 is3a12fd77(PR #655).Edits mapped to やること
chore/subset-font-2.9.0fromorigin/preview3a12fd77(order 6 merged). Bun 1.4.2 (1.4.2+744846f84) installed privately at/tmp/bun-1.4.2and prepended toPATH. Global Bun was not upgraded (bun upgradewas not run;~/.bunwas not written). Nodev24.20.0. NoPUBLIC_GA4_MEASUREMENT_ID/PUBLIC_X_PIXEL_ID/PUBLIC_META_PIXEL_ID.package.jsondevDependencies["subset-font"]:^2.5.0→^2.9.0.scripts/subset-fonts.tswas not edited. No other package range changed. Commit7ff75ef4.bun install(Bun 1.4.2). Resolvedsubset-font@2.9.0andharfbuzzjs@1.6.2. Exactly oneharfbuzzjspackage entry.lockfileVersionstayed1. See Lockfile greps.[subset-fonts]log diff. 4/4 files byte-identical, same content hashes as the 2026-09-24 dry run. Fallback (a)–(c) and the visual compare were not required. See Font oracle.7ff75ef4sogit diff --exit-codeis the generated-file check. All exit 0. Results match the dry-run table (typecheck / test / build / REQUIRE_BUILT_ARTIFACTS / verify:gates OK; Playwright 356 passed, 26 skipped, 0 failed;bun auditno vulnerabilities).CHANGELOG.md### Changed:- **subset-font 2.5.0 → 2.9.0 (harfbuzzjs 1.6)** — font subsets byte-identical.Commit7ff75ef4. The Issue's| changed (sizes …)alternative does not apply.docs/TOOLCHAIN.md§11 order 7:— done (#656). Follow-up commit4e93af49. subset-font has no §2 row; none added.Lockfile diff
git diff --numstat 3a12fd77for the bump (commit7ff75ef4, includes the one-line changelog):bun installwrotebun.lock; it was not hand-edited. The hunks are:"subset-font": "^2.5.0"→"^2.9.0".harfbuzzjs@0.10.3→harfbuzzjs@1.6.2.lodash@4.18.1. subset-font 2.9.0 no longer depends onlodash(2.5.0 declaredlodash: ^4.17.21). No other package entry referenced that key.lodash.defaults/lodash.differenceand the otherlodash.*packages stay.subset-font@2.5.0→subset-font@2.9.0(harfbuzzjs: ^1.6.1, nolodash).The dry-run table does not give a
bun.locknumstat. The grep checks in やること step 3 match the table.Lockfile greps
bun installlog (Bun 1.4.2, after the range bump):Installed packages:
subset-font2.9.0,harfbuzzjs1.6.2.Font oracle
unset PUBLIC_GA4_MEASUREMENT_ID PUBLIC_X_PIXEL_ID PUBLIC_META_PIXEL_ID.git stash+bun installbuilt on subset-font 2.5.0 (+ subset-font@2.5.0);git stash pop+bun installbuilt on subset-font 2.9.0 (+ subset-font@2.9.0). Bothbun run buildruns exited 0.diffof[subset-fonts]lines: empty (no log diff).Both sides:
These are the same four filenames as the dry-run table.
cmpreported identical for each. Step 4's fallback (codepoint counts already match, ±5 % sizes, Playwright, and the 1440 / 768 / 375 visual compare) was not run because the files did not differ.Verification (Bun 1.4.2+744846f84, Node v24.20.0)
Chain ran on commit
7ff75ef4. Each command exit 0.bun run typecheckbun run testbun run testrunsbuild:datathenbun test. ETL completed (556 occupations).sector.test.tsprints two[og] sectors projection schema mismatchlines. Same pre-existing negative fixtures noted on #655; the run is 1725 pass / 0 fail.bun run buildThe 844 route lines are omitted. CSP hashes unchanged.
REQUIRE_BUILT_ARTIFACTS=1 bun test scripts/home-css-loading.test.ts src/site/models-built.test.tsbun run verify:gatesbun x playwright test --reporter=linebun audit438 is one fewer than the order-6 run (439) because
lodash@4.18.1left the lockfile with subset-font. The dry-run table says "No vulnerabilities found" and does not pin a package count.git diff --exit-codeIssue #643 does not list
vercel inspector a previewcurl. Those checks are not in this PR.CI
gh pr checks 656on head4e93af49:The head commit is docs-only (
docs/TOOLCHAIN.md), soscripts/vercel-ignore-build.shskipped that build (exit 0 → skip). The code commit7ff75ef4deployed: Vercel statusDeployment has completedat https://vercel.com/zkscio/jobs/Cw9nj2CxJfPXAzmT9scGqo2gXGjo. Preview: https://jobs-git-chore-subset-font-290-zkscio.vercel.app.qualityon7ff75ef4was cancelled by the follow-up push (concurrency.cancel-in-progress, run 36018334775); the run that passed is the head run above.Issue #643 does not list
vercel inspector a previewcurl. Those commands were not run.