ci: fail-slow one-sweep CI (PR-0) - #784
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dfe645f38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8dfe645 to
e0e39b1
Compare
Codex review — resolutions (re-rolled head
|
|
To use Codex here, create an environment for this repo. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0e39b1117
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What
PR-0 (D4 from the CI-overhaul lane packet): every CI run surfaces ALL issues in one sweep, so a lane fixes everything in ONE commit + ONE push instead of micro-commits polling CI.
preflightandbackend: independent steps run!cancelled(); dependent steps guard onsteps.<id>.outcome == 'success'(checkout/setup-node/npm-ci/dotslash/rust-toolchainin preflight,topologyin backend). One root failure skips its dependents instead of cascading 20 reds.collect-failurescloses each job: prints the failing step ids (toJSON(steps)viascripts/ci-collect-failures.mjs) and exits 1, preserving the job-level red that feedsRequired / CI.cargo_needs_postgres.sh(default--keep-going,--fail-fastopt-out, per-binary PASS/FAIL summary) and thedomain-unitinline block (verbatim cargo invocations, summaryexit 1).scripts/check-ci-preflight.mjs(+test) re-locks the new ids/conditions/digests;scripts/lib/ci-workflow-executables.mjskeepscheck-executed-testsattributing every binary under the keep-goingci-keep-going:contract.No production code, no migration, no lockfile, no OpenAPI, no Buck target. Job display names and
required-cineeds:are unchanged.Rebased onto #773 (kept its unconditional index-0 backend Checkout + added
id: checkout).Verification (local)
node --test scripts/check-ci-preflight.test.mjs— 57 passednode --test scripts/verify.test.mjs— 13 passednode --test tools/ci/cargo-test-runner.test.mjs— 3 passednpm run check:ci-preflight— exit 0 (incl.check-mjs-dark-suites --strictdark_count 0)node scripts/check-executed-tests.mjs— 364 defined / 364 reachable / 1 baseline-pinned darknpm run check:doc-manifest— OK (453 files); reasoning-lens structural — OKactionlint .github/workflows/ci.yml— clean;git diff --check— cleanSigned C+T:
cf47da8c4(code) →8dfe645f3(ledger), both ED25519SHA256:5grGNUtX9Zgmy1SWne6wF9DR8W1ElUQaF/Z8SYRz8E8.