This repository was archived by the owner on Oct 13, 2024. It is now read-only.
New js tracking code for last piwik version - #4
Open
msergg wants to merge 1 commit into
Open
Conversation
dhuf
reviewed
Jan 22, 2018
| @@ -1,12 +1,17 @@ | |||
| <!-- Piwik --> | |||
| <!-- Start Piwik Tracking Code --> | |||
| <script type="text/javascript"> | |||
There was a problem hiding this comment.
Seems like the in HTML5 it give a Warning "The type attribute is unnecessary for JavaScript resources.", what do you think about removing it ?
Owner
There was a problem hiding this comment.
Hey, I didn't maintained this here for a very long time. Also https://github.com/jcassee/django-analytical makes a great job, so I abandoned my package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for update in pip repository