Skip to content

Added some quotes!#41

Open
shoobomb wants to merge 8 commits intojarmo:masterfrom
shoobomb:master
Open

Added some quotes!#41
shoobomb wants to merge 8 commits intojarmo:masterfrom
shoobomb:master

Conversation

@shoobomb
Copy link

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote this to be left out, because it doesn't seem anything special. @moll agree?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concur. Not much of an aphorism. >)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rectify it all today! Let me know about the white spaces problem, I'm
not getting where exactly white spaces are there! Are you talking about the
extra line? After each quote?
On 18-Jan-2016 12:10 am, "Andri Möll" notifications@github.com wrote:

In quotes.yaml
#41 (comment):

+- :c: Hope That Firewall works because your screwed...

Concur. Not much of an aphorism. >)


Reply to this email directly or view it on GitHub
https://github.com/jarmo/hackersays/pull/41/files#r49950275.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he's talking about trailing whitespace on line 32.

@jarmo
Copy link
Owner

jarmo commented Jan 17, 2016

Added some inline comments. I'm also pretty sure that you've added some quotes there, which already exists in quotes.yaml. Idea was to add only non-existing quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments