Split make_assets scripts by plot functions
#247
Conversation
DanielYang59
added
ux
assets/asset_makers/ptable/ptable_matplotlib/ptable_heatmap_splits_plotly.py
Outdated
Show resolved
Hide resolved
unused, left from bad merge conflict resolve
…y_hexbin_(hex_)with_hist
| plt.rc("font", size=14) | ||
| plt.rc("savefig", bbox="tight", dpi=200) | ||
| plt.rc("axes", titlesize=16, titleweight="bold") | ||
| plt.rc("figure", dpi=200, titlesize=20, titleweight="bold") | ||
| plt.rcParams["figure.constrained_layout.use"] = True | ||
|
|
There was a problem hiding this comment.
would be good to centralize these settings instead of repeating them in 15 asset scripts. if you import a file which has these commands at the top level, the settings will take effect
There was a problem hiding this comment.
Thanks for the help, it's super helpful :)
Yes of course, sorry I'm currently playing with Network UPS Tools trying to set it up for my toy server, I would get my hands on this later.
Also I might need to give the asset makers a complete check because for some reason the heatmap split plotter is more "sparse" than before
| | ---------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------- | | ||
| | [mlff_phonons.ipynb](https://github.com/janosh/pymatviz/blob/main/examples/mlff_phonons.ipynb) | [![Open in Google Colab][Open in Google Colab]](https://colab.research.google.com/github/janosh/pymatviz/blob/main/examples/mlff_phonons.ipynb) | [Launch Codespace][codespace url] | | ||
| | [matbench_dielectric_eda.ipynb](https://github.com/janosh/pymatviz/blob/main/examples/matbench_dielectric_eda.ipynb) | [![Open in Google Colab][Open in Google Colab]](https://colab.research.google.com/github/janosh/pymatviz/blob/main/examples/matbench_dielectric_eda.ipynb) | [Launch Codespace][codespace url] | | ||
| | [mp_bimodal_e_form.ipynb](https://github.com/janosh/pymatviz/blob/main/examples/mp_bimodal_e_form.ipynb) | [![Open in Google Colab][Open in Google Colab]](https://colab.research.google.com/github/janosh/pymatviz/blob/main/examples/mp_bimodal_e_form.ipynb) | [Launch Codespace][codespace url] | |
There was a problem hiding this comment.
pre-commit seems to add a duplicate for section hyperlink header for some reason
There was a problem hiding this comment.
that's the table header. every markdown needs to have one unfortunately. it can be empty but it needs to be there else it won't render as a table
There was a problem hiding this comment.
Thanks for letting me know, admittedly this un-rendered markdown is painful to look at.
Weird these headers were not added before, but this See the [/api][/api] page. doesn't seem like a table header?
mv tests/test/test_data.py to tests/test_data.py
…g_matplotlib to apply_matplotlib_template add unit test for apply_matplotlib_template() remove unneeded plotly templates from matplotlib asset scripts
|
Thanks for doing all heavy lifting :) I'm okay with merging this first (after fix those minor import issues) and apparently some asset makers are broken, which I believe it's not related to change here, but still worth extra attention |
…rups/powerups.py remove unused pmv.set_plotly_template
|
Oops, my bad, looks like a typo
|
janosh
added
docs
make_assetsscripts by plot functions, to close Splitmake_assetsscripts by plot function #245matplotlibuse non-interactive agg backend JaGeo/LobsterPy#349 (comment)pymatgenand drop temporarymontydependency