Merge pull request #461 from janl/fix/context-cache

Bugfix for view context cache
janl · Jun 4, 2015 · 15e7016 · 15e7016
2 parents e31a89a + e801e84
commit 15e7016
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/mustache.js b/mustache.js
@@ -356,7 +356,7 @@
     var cache = this.cache;
 
     var value;
-    if (name in cache) {
+    if (cache.hasOwnProperty(name)) {
       value = cache[name];
     } else {
       var context = this, names, index, lookupHit = false;

diff --git a/test/_files/avoids_obj_prototype_in_view_cache.js b/test/_files/avoids_obj_prototype_in_view_cache.js
@@ -0,0 +1,4 @@
+({
+  valueOf: 'Avoids methods',
+  watch: 'in Object.prototype'
+})
diff --git a/test/_files/avoids_obj_prototype_in_view_cache.mustache b/test/_files/avoids_obj_prototype_in_view_cache.mustache
@@ -0,0 +1 @@
+{{valueOf}} {{watch}}
diff --git a/test/_files/avoids_obj_prototype_in_view_cache.txt b/test/_files/avoids_obj_prototype_in_view_cache.txt
@@ -0,0 +1 @@
+Avoids methods in Object.prototype