Skip to content

Conversation

@djblue
Copy link
Contributor

@djblue djblue commented Dec 7, 2025

Fixes #605

% jank repl
user=> (+ 1 2 3)
6

user=> (ns foo {:a 1})
nil

foo=>  (ns ^{:a 1} foo)
nil

foo=>  (meta *ns*)
{:jank/source {:file "/tmp/jank-repl-aeq2nT", :start {:offset 12, :line 1, :col 13}, :end {:offset 15, :line 1, :col 16}}, :a 1}


namespace jank::runtime::behavior
{
template <typename T>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should split metadatable into two separate concepts? Some objects in Clojure have metadata, but don't support with-meta, so it feels like we need a concept that says: this objects supports reading metadata, but says nothing about how that metadata is set.

Also, I know this should be in its own file, putting it here temporarily.

@djblue djblue marked this pull request as ready for review December 7, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ns doesn't handle meta properly

1 participant