Skip to content

Parse string to bigint & bigdec #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shantanu-sardesai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Parse string to bigint & bigdec #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e1da9d
Parse number to `bigint`
shantanu-sardesai Dec 3, 2025
69b711f
Parse number to `bigdecimal`
shantanu-sardesai Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler+runtime/src/cpp/jank/runtime/core/math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,15 +1795,15 @@ namespace jank::runtime

obj::big_integer_ref to_big_integer(object_ref const o)
{
return visit_number_like(
return visit_object(
[&](auto const typed_o) -> obj::big_integer_ref {
using T = typename decltype(typed_o)::value_type;

if constexpr(std::same_as<T, obj::big_integer>)
{
return typed_o;
}
else if constexpr(std::same_as<T, obj::integer>)
else if constexpr(std::same_as<T, obj::integer> || std::same_as<T, obj::persistent_string>)
{
return make_box<obj::big_integer>(typed_o->data);
}
Expand All @@ -1828,7 +1828,7 @@ namespace jank::runtime

obj::big_decimal_ref to_big_decimal(object_ref const o)
{
return visit_number_like(
return visit_object(
[&](auto const typed_o) -> obj::big_decimal_ref {
using T = typename decltype(typed_o)::value_type;

Expand All @@ -1837,7 +1837,7 @@ namespace jank::runtime
return make_box<obj::big_decimal>(typed_o->to_real());
}
else if constexpr(std::same_as<T, obj::big_integer> || std::same_as<T, obj::real>
|| std::same_as<T, obj::ratio>)
|| std::same_as<T, obj::ratio> || std::same_as<T, obj::persistent_string>)
{
return make_box<obj::big_decimal>(typed_o->data);
}
Expand Down
Loading