Skip to content

fix(a11y): add aria-labels to login form elements #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prateek2007-cmd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): add aria-labels to login form elements #2254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<body>
<section id="header">
<!-- Logo -->
<a href="index.html">
<a href="index.html" aria-label="Home">
<img id="siteLogo" src="images/logo.png" alt="Cara Logo" />
</a>

Expand Down Expand Up @@ -50,7 +50,7 @@
<h2>Welcome Back!</h2>
<p class="subtitle">Please enter your details to sign in</p>

<form id="loginForm" class="login-form" novalidate>
<form id="loginForm" class="login-form" aria-label="Login form" novalidate>
<div class="input-group">
<label for="loginEmail">Email Address</label>
<input type="email" id="loginEmail" name="email" class="input-field" placeholder="Enter your email address"
Expand Down Expand Up @@ -89,15 +89,15 @@ <h2>Welcome Back!</h2>
<label>Login As</label>
<div class="role-selector">
<label class="role-option">
<input type="radio" name="loginRole" value="USER" checked />
<input type="radio" name="loginRole" value="USER" aria-label="Login as User" checked />
<span class="role-card">
<i class="ri-user-3-line"></i>
<strong>User</strong>
<small>Shop &amp; browse</small>
</span>
</label>
<label class="role-option">
<input type="radio" name="loginRole" value="ADMIN" />
<input type="radio" name="loginRole" value="ADMIN" aria-label="Login as Admin" />
<span class="role-card">
<i class="ri-shield-user-line"></i>
<strong>Admin</strong>
Expand All @@ -107,7 +107,7 @@ <h2>Welcome Back!</h2>
</div>
</div>

<button type="submit" class="login-btn"><span>Sign In</span></button>
<button type="submit" class="login-btn" aria-label="Sign In"><span>Sign In</span></button>
</form>

<div class="signup-link">
Expand Down Expand Up @@ -143,6 +143,4 @@ <h2>Welcome Back!</h2>
<script src="js/simple-captcha.js" defer></script>
</body>

</html>

<!-- TODO: Integrate aria labels for screen readers -->
</html>
Loading