fix(security): restrict CORS allow_methods to GET, POST, OPTIONS#2241
Open
nyxsky404 wants to merge 1 commit into
Open
fix(security): restrict CORS allow_methods to GET, POST, OPTIONS#2241nyxsky404 wants to merge 1 commit into
nyxsky404 wants to merge 1 commit into
Conversation
Wildcard allow_methods exposed DELETE, PUT, PATCH, TRACE etc. Limit to the three methods the API actually uses to reduce the cross-origin attack surface.
|
@nyxsky404 is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Description
allow_methods=["*"]in the CORS middleware exposedDELETE,PUT,PATCH,TRACE, and other HTTP methods to cross-origin requests.Replaced the wildcard with an explicit allowlist
["GET", "POST", "OPTIONS"]— the only three methods used by the API.OPTIONSis required for preflight requests.🔗 Related Issues
Fixes #2236
🧩 Type of Change
✅ Checklist