[Bug] ⌘N in the macOS desktop app opens a new app window instead of a new session (#70) - #85
Open
jan21deepak wants to merge 1 commit into
Open
[Bug] ⌘N in the macOS desktop app opens a new app window instead of a new session (#70)#85jan21deepak wants to merge 1 commit into
jan21deepak wants to merge 1 commit into
Conversation
Remap the standard new shortcut (Cmd/Ctrl+N) from opening an OS-level window to navigating the current window's SPA to the new-session landing via sendOpenPath. Move New Window to Cmd/Ctrl+Shift+N so the multi-window workflow remains accessible from the menu. Co-authored-by: jan21deepak <jan21deepak@users.noreply.github.com>
Owner
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bd07138. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically by Cursor Forge as a same-repo PR on
jan21deepak/omnigentafter the Cloud Agent pushed
cursor/fix-cmd-n-new-session-48f7(not against an upstream parent).Fixes #70.
Cursor agent:
bc-2d807766-87e5-48aa-9785-a07f1cae48f7Note
Low Risk
Menu accelerator and routing-only changes in the Electron shell; behavior is covered by wiring regression tests and matches existing
sendOpenPathnavigation.Overview
Fixes #70: on macOS/desktop, ⌘N / Ctrl+N no longer spawns another OS window.
The Server menu adds New Session on CmdOrCtrl+N, which calls
newSession()→sendOpenPath(activeWindow(), '/')so the SPA navigates in-place (sameomnigent:open-pathpath as deep links and notification clicks). New Window is remapped to CmdOrCtrl+Shift+N and still usesnewWindow().main.test.jsadds source-string guards so New Session keeps CmdOrCtrl+N +newSession(), and New Window cannot reclaim that shortcut.Reviewed by Cursor Bugbot for commit bd07138. Bugbot is set up for automated code reviews on this repo. Configure here.