add postcard & postcard-rpc re-exports for macros#110
Merged
jamesmunns merged 2 commits intojamesmunns:mainfrom Jul 8, 2025
Merged
add postcard & postcard-rpc re-exports for macros#110jamesmunns merged 2 commits intojamesmunns:mainfrom
postcard & postcard-rpc re-exports for macros#110jamesmunns merged 2 commits intojamesmunns:mainfrom
Conversation
the macros reference `postcard-schema` and expect their callers to add the dependency. this has two downsides: * this dependency leaks to the caller * we have no guarantee as to which version the caller adds (and with which features), thus we don't know whether it'll actually compile by re-exporting it and referencing our re-export we can resolve this issue. the re-export is hidden from the docs as consumers are not supposed to use it directly. note that the ICD example has not been modified since it explicitly uses `#[derive(Schema)]` and thus directly depends on the crate. resolves jamesmunns#105
the macro references `postcard` and expects its callers to add the dependency. this has two downsides: * this dependency leaks to the caller * we have no guarantee as to which version the caller adds (and with which features), thus we don't know whether it'll actually compile by re-exporting it and referencing our re-export we can resolve this issue. the re-export is hidden from the docs as consumers are not supposed to use it directly. resolves jamesmunns#105
jamesmunns
added
the
Q2 '25 Triage
jamesmunns
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the macros reference
postcard&postcard-schemaand expect their callers to add the dependency.this has two downsides:
by re-exporting it and referencing our re-export we can resolve this issue. the re-export is hidden from the docs as consumers are not supposed to use it directly.
resolves #105