Use abstract critical sections for thumbv6 #98
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the critical sections required for thumbv6 to use the abstraction provided by the
critical_section
crate. The context here is the RP2040 micocontroller, which is a two core Cortex-M0+ device, so just disabling interrupts on the current core is not sufficient when a bbqueue is used to communicate between cores. However, the HAL provides an implementation of a critical section hooking into the abstraction above to handle this kind of case.With this change, using bbqueue on single core thumbv6 target (equivalent to the current behavior) looks like:
Or for a RP2040 in multi-core mode: