-
Notifications
You must be signed in to change notification settings - Fork 72
Add support for rubocop >= 0.53.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rubocop >= 0.53.0 #33
Conversation
👍 |
This looks like an almost-identical copy of the existing PR #31 I vote to merge one or the other of these; have explained my reasoning at greater length in the other PR. |
@olliebennett obviously I'm a little biased 😉. I agree, we should get one of these merged because the deprecation warnings are annoying. |
Is there any news on one of these fixes being merged and made official? |
+1 to get this merged |
Checking in with maintainers on any updates with resolving the rubocop dependency deprecation warning that #33 and #31 solve. Thanks! cc: @jakeonrails |
+1 to merge this |
Hey everyone I'm very sorry but it's been hard for me to give this my attention. I will spend some time today to sort through this PR and the other one and see about getting this fix merged and pushed up to Rubygems. |
Seems like either this or #31 should do this. |
Thanks @rosscooperman |
@bak1an @jakeonrails thanks for getting this in. any chance you could push this up to rubygems as well? |
@bauerjon Should be there now. |
Updates trailing comma configuration to be compatible with rubocop >= 0.53.0 (and resolve deprecation warnings for
Style/TrailingCommaInLiteral
)