Skip to content

Add support for rubocop >= 0.53.0 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rosscooperman
Copy link
Contributor

Updates trailing comma configuration to be compatible with rubocop >= 0.53.0 (and resolve deprecation warnings for Style/TrailingCommaInLiteral)

@DamienMetzger
Copy link

👍

@olliebennett
Copy link

This looks like an almost-identical copy of the existing PR #31

I vote to merge one or the other of these; have explained my reasoning at greater length in the other PR.

@rosscooperman
Copy link
Contributor Author

@olliebennett obviously I'm a little biased 😉. I agree, we should get one of these merged because the deprecation warnings are annoying.

@maplealmond
Copy link

Is there any news on one of these fixes being merged and made official?

@brafales
Copy link

+1 to get this merged

@4justinstewart
Copy link

Checking in with maintainers on any updates with resolving the rubocop dependency deprecation warning that #33 and #31 solve. Thanks! cc: @jakeonrails

@newbray
Copy link

newbray commented Nov 27, 2018

+1 to merge this

@jakeonrails
Copy link
Owner

Hey everyone I'm very sorry but it's been hard for me to give this my attention. I will spend some time today to sort through this PR and the other one and see about getting this fix merged and pushed up to Rubygems.

@bak1an
Copy link
Collaborator

bak1an commented Feb 11, 2019

Seems like either this or #31 should do this.

@bak1an
Copy link
Collaborator

bak1an commented Feb 12, 2019

Thanks @rosscooperman

@bak1an bak1an merged commit 945f1e8 into jakeonrails:master Feb 12, 2019
@rosscooperman rosscooperman deleted the fix-rubocop-deprecation-warnings branch February 13, 2019 02:20
@bauerjon
Copy link

bauerjon commented Feb 13, 2019

@bak1an @jakeonrails thanks for getting this in. any chance you could push this up to rubygems as well?

@bak1an
Copy link
Collaborator

bak1an commented Mar 8, 2019

@bauerjon Should be there now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants