Skip to content

Replace HTTP 403 error status with HTTP 400 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace HTTP 403 error status with HTTP 400 #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/routes/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ helper.validate = (someObject, someDefinition, callback) => {
Joi.validate(someObject, someDefinition, { abortEarly: false }, (err, sanitisedObject) => {
if (err) {
return callback({ // eslint-disable-line standard/no-callback-literal
status: '403',
code: 'EFORBIDDEN',
status: '400',
code: 'EBADREQUEST',
title: 'Param validation failed',
detail: err.details
})
Expand All @@ -28,17 +28,17 @@ helper.validate = (someObject, someDefinition, callback) => {
helper.checkForBody = (request, callback) => {
if (!request.params.data) {
return callback({ // eslint-disable-line standard/no-callback-literal
status: '403',
code: 'EFORBIDDEN',
status: '400',
code: 'EBADREQUEST',
title: 'Request validation failed',
detail: 'Missing "data" - have you sent the right http headers?'
})
}
// data can be {} or [] both of which are typeof === 'object'
if (typeof request.params.data !== 'object') {
return callback({ // eslint-disable-line standard/no-callback-literal
status: '403',
code: 'EFORBIDDEN',
status: '400',
code: 'EBADREQUEST',
title: 'Request validation failed',
detail: '"data" must be an object - have you sent the right http headers?'
})
Expand Down