Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Change metrics port in kafka ingester config to avoid conflict with collector #6678

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • The OTEL collector upgrade was failing because of a conflict in ports between the kafka collector and ingester which were both binding to :8888. This PR changes the port that the ingester listens on

How was this change tested?

  • CI

Checklist

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (1b158e5) to head (af1759d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6678      +/-   ##
==========================================
+ Coverage   95.96%   95.99%   +0.02%     
==========================================
  Files         363      363              
  Lines       20601    20601              
==========================================
+ Hits        19770    19775       +5     
+ Misses        634      630       -4     
+ Partials      197      196       -1     
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.93% <ø> (+0.11%) ⬆️
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.81% <ø> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 57ce1b4 into jaegertracing:main Feb 5, 2025
55 checks passed
@mahadzaryab1 mahadzaryab1 deleted the fix-kafka-port branch February 5, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants