[CI] Add workflow to guard against increases in the binary size #6529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6529 +/- ##
==========================================
- Coverage 96.23% 96.21% -0.03%
==========================================
Files 372 372
Lines 21371 21371
==========================================
- Hits 20567 20562 -5
- Misses 612 616 +4
- Partials 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 11, 2025
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Jan 13, 2025
Signed-off-by: chahatsagarmain <[email protected]>
…/jaeger into jaeger-bundle-ci Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Jan 15, 2025
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Jan 15, 2025
yurishkuro
added
the
changelog:ci
yurishkuro
changed the title
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: chahat sagar <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: chahat sagar <[email protected]>
yurishkuro
reviewed
Jan 15, 2025
| contents: read | ||
|
|
||
| jobs: | ||
| build-and-check: |
There was a problem hiding this comment.
let's move this as yet another job into .github/workflows/ci-lint-checks.yaml so that it runs as part of the overall lint group.
Suggested change
| build-and-check: | |
| binary-size-check: |
yurishkuro
reviewed
Jan 15, 2025
Comment on lines
30
to
32
| - name: Fetch git tags | ||
| run: | | ||
| git fetch --prune --unshallow --tags |
There was a problem hiding this comment.
is this necessary? We don't rely on tags in this workflow
There was a problem hiding this comment.
we dont need it , this was used here
so i let it be , This can be removed .Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Jan 15, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test