Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Add Meter Provider To Telemetry Settings #6132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[jaeger-v2] Add Meter Provider To Telemetry Settings #6132

wants to merge 1 commit into from
+2 −0

Conversation

Garvit-77
Copy link

Which problem is this PR solving?

Description of the changes

  • Added the Meter Provider to telemetry Settings.go

Checklist

@Garvit-77 Garvit-77 requested a review from a team as a code owner October 27, 2024 20:23
@Garvit-77 Garvit-77 requested a review from jkowall October 27, 2024 20:23
@dosubot dosubot bot added the v2 label Oct 27, 2024
@Garvit-77
Copy link
Author

Garvit-77 commented Oct 27, 2024 •
edited
Loading

@mahadzaryab1 The metric.NewMeterProvider has an Option input
(https://pkg.go.dev/go.opentelemetry.io/otel/sdk/metric#NewMeterProvider)
With reader, with resoures, with view

yurishkuro
yurishkuro requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no value in this change unless this provider is wired in and used where appropriate

@Garvit-77
Added OTEL's meter provider
18f38b2 
Signed-off-by: Garvit Khandelwal <[email protected]>
@Garvit-77
Copy link
Author

there's no value in this change unless this provider is wired in and used where appropriate

the MeterProvider msut be initialized with Which option Reader, Resources or Views
@yurishkuro

@yurishkuro
Copy link
Member

we don't need to initialize it, in jaeger-v2 it is already provided. When used in v1 context we can use noop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro requested changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jaeger-v2] Add Meter Provider To Telemetry Settings
2 participants
@Garvit-77 @yurishkuro