Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reporter (agent) flags from all in one #2829

Merged

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Feb 17, 2025

Which problem is this PR solving?

  • When agent was removed from jaeger , reporter flags were removed from all in one binary. so those flags are not valid anymore.

Description of the changes

  • Remove reporter flags, as those are specific flags for report to the agent. which is not anymore present in the all in one.

How was this change tested?

  • Deployed on kubernetes cluster and did an all in one deployment

Checklist

@rubenvp8510 rubenvp8510 force-pushed the remove_reporter_agent_flags branch 2 times, most recently from d494397 to 6e81009 Compare February 18, 2025 05:10
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (3edc1af) to head (3735c2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
- Coverage   74.63%   74.58%   -0.05%     
==========================================
  Files         124      124              
  Lines       10513    10505       -8     
==========================================
- Hits         7846     7835      -11     
- Misses       2470     2472       +2     
- Partials      197      198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubenvp8510 rubenvp8510 force-pushed the remove_reporter_agent_flags branch from 6e81009 to 3735c2f Compare February 18, 2025 05:16
@iblancasa iblancasa merged commit 830b916 into jaegertracing:main Feb 20, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants