Repository navigation
feat: preserve pinned RTPTorrent class execution evidence - #290
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Consolidated corrections in b5092e2 address the seven initial Sonar findings: simplified numeric regexes retain explicit Repeated local OpenCodeReview 1.12.13 workspace and full main-to-HEAD delegation/rules review covers all 11 files: five selected, six manual exclusions, including full fixture values. No confirmed critical/high/medium issue remains locally. Please review the current head. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review 13f5d05 resolves the additional S8786 finding by matching mantissa and exponent separately, removing ambiguous backtracking while preserving the ASCII-only grammar. A regression checks that 64-character zero is accepted and 65-character zero rejects; the documented resource limit is explicit. The original seven Sonar findings were already corrected in b5092e2. Final full suite after this correction: 2,035 passed, 95.31% combined coverage. All 63 adapter unit cases, the installed-wheel/native-checkpoint workflow, static typing, lint/format, Pylint, docstrings, structural checks, strict docs and builds pass. Reconverted the real pinned 46,995-row source successfully with admission still blocked. Repeated OpenCodeReview 1.12.13 local delegation workspace/full-range review and manual exclusions cover all 11 changed files; no confirmed critical/high/medium finding remains locally. Please review the current head. |
|
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |



Problem and resulting behavior
RTPTorrent’s raw files contain job-level class executions, repeated class labels, reported seconds and partial method counts. Published baseline tables are filtered slices; treating them as complete CI history or inventing missing completion times can distort zero-failure coverage and leak outcomes.
Add a bounded, version-pinned source-assessment slice for #261. The typed dataset preserves project/job/class/position execution identity, provenance, exact reported seconds, explicit observed/unavailable duration status, partial method counts and duplicate-exclusion counts. It always exposes the unresolved temporal-admission blocker. The issue remains open.
Architecture and contract
MaterializationSpec, immutable externalSourceCache, byte verification,ArtifactWriter, manifest, native runner and learning checkpoints.RTPTorrentSpec/RTPTorrentDatasetschema v1 with recipertptorrent-class-results-v1, source format 1.1 and the exact eight-column raw layout. Filtered baseline layouts, unknown versions and implicit migration reject.Zero reported seconds remain observed zero. Empty duration is null/unavailable. Invalid negative/nonfinite/overprecision durations reject, including compact exponent amplification corrected in #288 / 4.4.1. Failure/error counts remain distinct from unique faults; skipped/unknown rows never become passes. Reported class elapsed time is not runner occupancy or parallel CI latency.
Use and reproducibility
docs/rtptorrent.mdsupplies the complete owned materialization/conversion example, primary-source assessment, exact source/member identities, compatibility rules, resource bounds and Mermaid diagram.examples/rtptorrent/ci.pyruns one owned constructed isolated serial job through the real Random/RNFail native pipeline, checks independent exact metric references and reopens its checkpoint. Installed-wheel testing copies/runs it twice outside the checkout and executes the complete documentation example.Manual source check (network-free conversion after acquisition): the exact HikariCP raw member produced 46,995 executions / 1,662 jobs, retaining 23,302 repeated-class executions, no duplicate exclusions and 1,530 jobs without reported class failures/errors. Its filtered untreated baseline contains 4,611 rows / 125 jobs and no such green jobs. These are descriptive source counts, not independent verification of whole-job success or policy effectiveness. Member digests are not archive digests. No third-party source rows are committed.
Validation and local review
pytest -n4 --cov --cov-branchwith real Syft available.make lint format-check typecheck interrogate cost-structural docs build,pylint -E colemanandgit diff --check: passed.Compatibility, migration and limits
No existing artifact is reinterpreted or automatically migrated. Source JSON checks model invariants;
validate_rtptorrent_datasetchecks correspondence against actual pinned cache bytes. Recipe-only converted rows remain local. Input bounds are 16 MiB per selected member, 50,000 physical data rows, 16 KiB per physical line and 1,024 characters per field and 64 characters per duration literal; these are not an OS memory sandbox.Temporal admission remains blocked: raw tables lack event/completion clocks and complete build/job mapping, and repeated class labels lack module/configuration disambiguation. The original paper’s metadata snapshot differs from the accessible dump; join equivalence/coverage remain unverified. Full RTPTorrent archive acquisition is incomplete; its ZIP64 layout / 2,883 entries exceed the existing v1 materializer contract, which is unchanged. The original paper also reports negative runner-duration defects; this reader rejects those rows without silent repair.
The registry/diversity matrix and its seven uncovered real-evidence regimes remain unchanged. The owned native slice establishes functional compatibility, not an observed CI timeline, generalization, policy superiority or elapsed-time savings. Subsequent #261 work covers LRTS, controlled fault corpora, configurable/synthetic stress, comparable baselines/statistics and protected confirmation/reporting.