Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape % to avoid "invalid capture index problem" when % in the input #410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ilan-schemoul
Copy link

Hey,
If you select a line with a "%" for example
" while (fscanf(src, "%30s ", str) == 1) "
And try to run a ChatGPTRun command such as code_readbility_analysis you will have an error invalid capture index lua/chatgpt/flows/actions/chat/init.lua:52
The reason it happens is that when there is a % it is interpreted as a capture index by gsub but of course it is not intended. We need to escape those.
The resulting code is value = value:gsub("%%", "%%%%") because inside a string the % themselve need to be escaped too.
It it tested and fix the problem on my side.

PS : I had to close previous PR because I made commit from other PRs mistakenly

@ilan-schemoul
Copy link
Author

@jackMort any feedback ?
I also havee two other pendings PR so feel free to review those when you can too

@devshoe
Copy link

devshoe commented Apr 4, 2024

I am facing this issue as well, in Go it deletes % from formatted strings and gives me completely nonsense answers. Do you have a workaround?

@devshoe
Copy link

devshoe commented Apr 4, 2024

I just pulled your branch and used it and it's fixed :) Thanks so much, I hope this PR gets merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants