Update subtitle_merger.py - #3
Open
itashia wants to merge 1 commit into
Open
Conversation
refactor: improve code quality with typing, modularity, and advanced logging - Added type hints to all methods and parameters for better readability and IDE support - Enhanced temporary file management using context managers (__enter__, __exit__) - Specialized handling of temporary files for robustness - Replaced print statements with Python logging module for leveled error/info messages - Implemented parallel processing with ThreadPoolExecutor for concurrent UTF-8 file conversion - Modularized code by splitting into smaller single-responsibility methods - Introduced SubtitleInfo class for metadata management - Added from_directory method to process all files in a directory - Improved ASS file header details - Better error and exception handling throughout - Replaced string-based paths with pathlib.Path for improved path management - Added comprehensive docstrings and clearer comments for complex sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: improve code quality with typing, modularity, and advanced logging