Net code: model index bit count update #246
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
commented
Mar 1, 2025
|
|
||
| Utils::Hook::Set(&netfield.bits, std::max(15u, newBitLength)); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not entirely sure whether this second netfield loop is required. If it is, it's probably easiest to set all bit counts of all 15 index netfields to a bit count of 15 (they are currently set to 10, 11 or 15).
This probably could use some more investigating and testing.
|
The protocol version you're looking for is in Structs.hpp i believe :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR expands the list of model indices that need to be increased to handle the increased model count.
How does this PR change IW4x's behaviour?
This changes the network code, so the server and client both need to be updated. Additionally, demo playback will break forward and backward compatibility due to the network code change. Maybe it's possible to check the protocol when playing back a demo and revert this change if necessary.
I presume network changes are reflected in a protocol value somewhere, which would need to be updated.
Anything else we should know?
This is untested.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)