chore(deps): bump ascom-alpaca to integration tip incl. tracking-rate-write fix#212
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Pulls in the rebuilt `integration` branch of ascom-alpaca-rs, which now includes the enum-repr fix that maps `serde_repr` variant rejections (e.g. `TrackingRate=5` or `-1` on the star-adventurer-gti driver) to ASCOM `INVALID_VALUE` instead of HTTP 400. Refreshes `MODULE.bazel.lock` accordingly.
ivonnyssen
force-pushed
the
worktree-tracking-rate-write
branch
from
628763d to
a4e9c24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ascom-alpacapin frome0431c1f→638429b2on theintegrationbranch of the fork.MODULE.bazel.lockto match.The new
integrationtip includes PR #14 on ascom-alpaca-rs with a new follow-up commit that mapsserde_reprenum-variant rejections to ASCOMINVALID_VALUE. This fixes theTrackingRate WriteConformU finding documented indocs/services/star-adventurer-gti.md(lines 622-624) where invalidDriveRateintegers (5,-1) were being rejected with HTTP 400 instead of HTTP 200 +ErrorNumber=0x401.Driver-side code is unchanged —
set_tracking_rateinservices/star-adventurer-gti/src/mount_device.rs:525already returnedINVALID_VALUEfor non-sidereal rates; the upstream framework now reaches that handler for out-of-enum-range integers too.Test plan
cargo check -p star-adventurer-gti --all-featurescleanbazel build //services/qhy-focuser/...clean (crate_universe resolves new pin)TrackingRate Write ×2entries should drop off the expected-issues list indocs/services/star-adventurer-gti.mddocs/services/star-adventurer-gti.md:622-624to be updated in a follow-up after ConformU verification🤖 Generated with Claude Code