Skip to content

Fixed incorrect config import/dependancy on DeleteJob #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alexgarrettsmith wants to merge 1 commit into
base: L5
Choose a base branch
from
Open

Fixed incorrect config import/dependancy on DeleteJob #91

alexgarrettsmith wants to merge 1 commit into from

Conversation

@alexgarrettsmith
Copy link

@alexgarrettsmith alexgarrettsmith commented Jun 10, 2015

Issue when ->delete()ing on models.

A quick side note, it might be nicer to use

$this->app = $app;
$this->config = $app->config;

for dependancy injection. If you agree, I can add this to the PR.

@alexbowers
Copy link

alexbowers commented Aug 5, 2015

Need this merged. This fixes the issue.

@julianrichen
Copy link

julianrichen commented Aug 6, 2015

Merging this would really be nice :)

@aqlx86 aqlx86 mentioned this pull request Sep 11, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexgarrettsmith @alexbowers @julianrichen