Laravel 5 Branch #71
Laravel 5 Branch #71
Conversation
The command 'php artisan larasearch:paths --dir=app --relations 'App\MySearchableModel' --write-config' did not work any more. Fix to reflect the changes in Laravel 5: - config folder has now changed to /config/ + now checking for the larasearch.php file instead of the package config folder - 'config:publish' is now 'vendor:publish'
PathCommand --write-config updated to Laravel 5
|
Thanks for the effort! I'm not using Laravel 5.0 myself yet but I definitely want to make it available to Laravel 5.0 users as soon as possible. I'll review the code tomorrow and come up with a version number. |
|
Perfect lol |
|
@pfeiferchristopher Thanks. |
|
@iverberk did you get a chance to look over this code? I just tried installing Larasearch again but looks like it still installed the L4.2 version. |
|
@iverberk any progress? |
|
@thangngoc89 it seems to work. I haven't had much time to work on it but I was able to get it pulled in and when I ran the |
|
@pfeiferchristopher my orginal project dosen't require elastic search anymore so i don't have enough time to investigate about this. I ask that question because I'm cleaning my repo list |
|
By bad I thought you tagged me because I got the email haha. I'd like to see this merged as well. |
|
@pfeiferchristopher when did I tag you ? |
|
I said I thought you did because I got the email. You didn't. |
|
@thangngoc89 one thing I have noticed is when running the during the first batch. Going through the code I found this in if ($results['errors'])and by changing it to if ( array_key_exists('errors', $results) )I was able to successfully index my Model and search correctly against it. I haven't got to having As for you saying you're cleaning up your repo, is it possible for me to fork your changes and host them myself until @iverberk is able to look them over and merge the pull request? |
4 participants
I'm new to Elastic Search and your package help me do a lot of magic things. Now, I need it in my Laravel 5 project so I modify some file to make it work with Laravel 5 (no back-compatibility with Laravel 4.2). I hope this is a good start for Larasearch in Laravel 5