Add section "return multiple nodes"#4
Merged
itsdouges merged 6 commits intoitsdouges:masterfrom Jan 3, 2020
Merged
Conversation
bendtherules
changed the title
bendtherules
changed the title
itsdouges
reviewed
Jan 3, 2020
| // If it is a expression statement, | ||
| if (ts.isExpressionStatement(node)) { | ||
| // Clone it | ||
| const newNode = ts.getMutableClone(node); |
Owner
There was a problem hiding this comment.
watch out for this - ts-loader doesn't play nicely (theres a section at the bottom of the handbook that mentions this). only found this out yesterday hehe
could you re-do this with either updateExpressionStatement or just returning the node twice?
[node, node]
Owner
|
love it, just the one comment |
Contributor
Author
|
Done. I hope ts-loader supports it well in the future. Although it works here, little concerned with moving a node around without cloning as it contains reference to its position in the source file and such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2.
Added doc and example.